grpc-js-xds: Implement and enable security interop tests #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection injector
1 task
murgatroid99
added a commit
to grpc/psm-interop
that referenced
this pull request
Feb 27, 2025
This requires the test implementation in grpc/grpc-node#2909 to work. Test run: - [x] [grpc/node/master/psm-security](https://source.cloud.google.com/results/invocations/369e192d-9c64-4475-b236-55ae6155410b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also includes a variety of fixes to make those tests pass:
Fix parsing of SAN entries to correctly handle colons in names.
Handle unset
CommonTlsContext.validation_context_type.Handle unset
filter_chain_match.Add
Serverprotected methodsexperimentalRegisterListenerToChannelz,experimentalUnregisterListenerFromChannelz, andexperimentalCreateConnectionInjectorWithChannelzRef.Modify
ServerCredentialsto separate options that are used once onHttp2Serverconstruction from options that can be updated such as by a certificate provider.Make transport and channel credentials connection establishment code handle and report more connection errors.
Wait for credentials information to be loaded from certificate providers before starting to connect, to avoid a time gap between creating a TCP connection and starting the TLS handshake.
Fix IPv6-mapped IPv4 address parsing in channelz, and represent them as IPv4 addresses.
Add error handling and logging for
tls.createSecureContext.grpc/node/master/psm-security